Misc file tweaks #329
Closed
Misc file tweaks #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elsassph
reviewed
Feb 23, 2021
elsassph
reviewed
Feb 23, 2021
TwitchBronBron
force-pushed
the
misc-file-tweaks
branch
from
5202a3f to
f348678
Compare
elsassph
reviewed
Feb 27, 2021
| * Given a pkgPath, remove the `pkg:/` portion of the path. | ||
| */ | ||
| public removePkgProtocol(pkgPath: string) { | ||
| if (pkgPath.startsWith('pkg:/')) { |
There was a problem hiding this comment.
Handled in 50a1555
| pkgPath = pkgPath.replace(/\\/g, '/'); | ||
| return 'pkg:/' + pkgPath; | ||
| if (!pkgPath.startsWith('pkg:/')) { |
There was a problem hiding this comment.
Handled in 50a1555
| if (targetPath === 'pkg:') { | ||
| public getPkgPathFromTarget(sourcePkgPath: string, targetPath: string) { | ||
| //handle some edge cases | ||
| if (targetPath === 'pkg:' || targetPath === 'pkg:/') { |
There was a problem hiding this comment.
Handled in 50a1555
This was referenced Feb 27, 2021
Merged
This was referenced Mar 28, 2021
Closed
Merged
|
Closing in favor of #399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some internal changes that I've been wanting to make for a while. These are breaking changes, but I'd rather get them in now before more projects start to depend on brighterscript and would have a more wide-reaching impact.
Notable changes:
pathAbsolutetosrcPathfor brevity and claritypkgPathstrings now contain an actual pkg path (i.e."source/main.brs"is now"pkg:/source/main.brs")pkgPathoriginally stored the platform-specific path separator (\on windows,/on everything else). NowpkgPathalways stores the unix separator because that's what is used on the roku device.programfile functions to auto-detect the path type and use the correct file collection (this.filesorthis.pkgMap) accordingly.program.filesandprogram.pkgMapnow store their keys in all lower case, which removes the need to iterate the collection to find filesnormalizePath: booleanparameter toprogram.getFileto support skippingutil.standardizePathwhen the caller knows the path has already been normalized