Add plugin build flag #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like you can find the user's plugin directory from the |
|
We don't currently account for this with the |
Dekkonot
requested changes
Jul 14, 2023
|
Also we have a benchmark in |
Merged
Closed
Dekkonot
reviewed
Jul 16, 2023
|
Minor nitpick with the punctuation and then looks good to me |
Co-authored-by: Micah <[email protected]>
Dekkonot
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #715.
It will not output to the correct place if the user configures the location of their plugin folder. That functionality would have to be added to
roblox_install. I haven't looked into whether it's possible or not yet.Here is what the output looks like:
I wasn't able to get the error cases to say "rojo build" in the usage section.