-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to clap v4 #724
Upgrade to clap v4 #724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I don't care about the formatting changes and the loss of colors is... tragic, but acceptable in my opinion. Hesitantly, I think this is fine with me.
What does the alternative for not upgrading look like? I know it wouldn't display as exclusive in help
but is that necessarily a deal breaker? We could always just raise an error if both fields are filled in.
Co-authored-by: Micah <[email protected]>
That's kind of a funky syntax. I know it's not something you can control, but I don't like it. That said, it's not a deal breaker because most people will probably just be memorizing how to use a command anyway. Would like to hear @Kampfkarren's and @kennethloeffler's inputs on this too, since it's a bit more of a design choice than normal and I want to make sure that multiple eyes okay it. |
taking away my colors? Everything is already gray enough 😭 Jokes aside... I agree with dekkonot, the changes to formatting/colors aren't a big problem, but it may be a smarter engineering decision to hold off on upgrading until we have a more compelling reason to do it (like maybe another mutually exclusive set of flags, or anywhere else we could use other new clap features) |
I need clap v4 for my planned changes for #715 because it has a new feature called argument relations. I can use the feature to stop users from using
project
andoutput
flags at the same time.New output
Clap changes the output from v3 to v4. Here's what the difference looks like:
Clap v3
Clap v4
Notice the lack of colors, the new casing, the bold, and the underlines.
Changes
""
for paths. Instead, I use the actual paths likedefault.project.json
. Now it shows up in the help output: