Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saturn Release Informational Maintenance + RPIP-49 #273
Saturn Release Informational Maintenance + RPIP-49 #273
Changes from 4 commits
e11833d
76766a8
79b9bd5
d34c94d
2eb5bb0
c57e000
30faaf1
8935972
a5c9023
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or "4 ETH bonds for all validators"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it's 4-8-4-*? So not sure I can say that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? Each new validator will require an additional 4 ETH bond. The array will go 4-8-12-16-*, but each index is how much capital you need for the next validator (4th validator requires 16 ETH or 4ETH bond per validator)?
Maybe "4 ETH bond per validator"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like "4 ETH bond per validator"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible I've been misunderstanding this for ages lol. Is it not:
4 ETH for first.
12 ETH for second.
16 ETH for third.
?
I thought the array value was the delta that you needed, not the total?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to think it out tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is total amount you need, so Saturn 1 is flat 4ETH bonds
Total per index: [4,8,12,…]
Alternatively just the “extra cost per index: [4,4,4,…]
Saturn changes to:
[4,8,9.5,11,13.5…]
or
(Additional cost): [4,4,1.5,1.5,1.5,…]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming samus has it right