-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saturn Release Informational Maintenance + RPIP-49 #273
Saturn Release Informational Maintenance + RPIP-49 #273
Conversation
While fixing the order of things do you want to also place the contents section in rpip order? |
RPIPs/RPIP-49.md
Outdated
* RPL issuance rewards no longer have a minimum stake required | ||
* RPL Value Capture - Increased share to voting Node Operators. | ||
* [RPIP-42: Bond curves](RPIP-42.md) - Partial Inclusion | ||
* 4 ETH minimum bond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* 4 ETH minimum bond | |
* 4 ETH bonds only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or "4 ETH bonds for all validators"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically it's 4-8-4-*? So not sure I can say that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? Each new validator will require an additional 4 ETH bond. The array will go 4-8-12-16-*, but each index is how much capital you need for the next validator (4th validator requires 16 ETH or 4ETH bond per validator)?
Maybe "4 ETH bond per validator"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like "4 ETH bond per validator"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean? Each new validator will require an additional 4 ETH bond. The array will go 4-8-12-16-*, but each index is how much capital you need for the next validator (4th validator requires 16 ETH or 4ETH bond per validator)?
Maybe "4 ETH bond per validator"?
Possible I've been misunderstanding this for ages lol. Is it not:
4 ETH for first.
12 ETH for second.
16 ETH for third.
?
I thought the array value was the delta that you needed, not the total?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to think it out tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is total amount you need, so Saturn 1 is flat 4ETH bonds
Total per index: [4,8,12,…]
Alternatively just the “extra cost per index: [4,4,4,…]
Saturn changes to:
[4,8,9.5,11,13.5…]
or
(Additional cost): [4,4,1.5,1.5,1.5,…]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming samus has it right
Not important but if you want to go through and keep convention discussed earlier of no periods on bullets (unless multiple sentences) then you could update that... But I think it's fine to leave alone if you don't want to |
Yeah, I'll do this tomorrow / later. Ran out of time today. |
Might do, will go through. |
So, I looked up bullet formatting a bit. Some rules I found are:
I tweaked some so it was less obviously inconsistent, but bleh, is fine. It's a super minor thing. |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now
I simplified the entries under 55 and 56 a bit, I think it's better that those sections are primarily just lists of RPIPs rather than trying to explain what exactly is in them, that should probably be left to the RPIPs themselves or a link to a blog post or other more readable document.
Reordered RPIP-49 list to be in RPIP order as it was bugging me. Minor rewords that I probably didn't need to make.