Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saturn Release Informational Maintenance + RPIP-49 #273

Merged

Conversation

LongForWisdom
Copy link
Contributor

I simplified the entries under 55 and 56 a bit, I think it's better that those sections are primarily just lists of RPIPs rather than trying to explain what exactly is in them, that should probably be left to the RPIPs themselves or a link to a blog post or other more readable document.

Reordered RPIP-49 list to be in RPIP order as it was bugging me. Minor rewords that I probably didn't need to make.

@orangesamus
Copy link
Collaborator

While fixing the order of things do you want to also place the contents section in rpip order?

RPIPs/RPIP-49.md Outdated
* RPL issuance rewards no longer have a minimum stake required
* RPL Value Capture - Increased share to voting Node Operators.
* [RPIP-42: Bond curves](RPIP-42.md) - Partial Inclusion
* 4 ETH minimum bond
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* 4 ETH minimum bond
* 4 ETH bonds only

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "4 ETH bonds for all validators"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it's 4-8-4-*? So not sure I can say that.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? Each new validator will require an additional 4 ETH bond. The array will go 4-8-12-16-*, but each index is how much capital you need for the next validator (4th validator requires 16 ETH or 4ETH bond per validator)?

Maybe "4 ETH bond per validator"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like "4 ETH bond per validator"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean? Each new validator will require an additional 4 ETH bond. The array will go 4-8-12-16-*, but each index is how much capital you need for the next validator (4th validator requires 16 ETH or 4ETH bond per validator)?

Maybe "4 ETH bond per validator"?

Possible I've been misunderstanding this for ages lol. Is it not:
4 ETH for first.
12 ETH for second.
16 ETH for third.
?

I thought the array value was the delta that you needed, not the total?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to think it out tomorrow.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is total amount you need, so Saturn 1 is flat 4ETH bonds
Total per index: [4,8,12,…]
Alternatively just the “extra cost per index: [4,4,4,…]

Saturn changes to:
[4,8,9.5,11,13.5…]
or
(Additional cost): [4,4,1.5,1.5,1.5,…]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming samus has it right

RPIPs/RPIP-49.md Outdated Show resolved Hide resolved
@orangesamus
Copy link
Collaborator

Not important but if you want to go through and keep convention discussed earlier of no periods on bullets (unless multiple sentences) then you could update that... But I think it's fine to leave alone if you don't want to

@LongForWisdom
Copy link
Contributor Author

While fixing the order of things do you want to also place the contents section in rpip order?

Yeah, I'll do this tomorrow / later. Ran out of time today.

@LongForWisdom
Copy link
Contributor Author

Not important but if you want to go through and keep convention discussed earlier of no periods on bullets (unless multiple sentences) then you could update that... But I think it's fine to leave alone if you don't want to

Might do, will go through.

@LongForWisdom
Copy link
Contributor Author

So, I looked up bullet formatting a bit. Some rules I found are:

  1. Use period if it contains a sentence (even if just one)
  2. Don't use a period if it's a single word or item.
  3. Don't use a period if it's completing a 'stem.'
  4. Don't mix lists of items and sentences.

I tweaked some so it was less obviously inconsistent, but bleh, is fine. It's a super minor thing.

@orangesamus
Copy link
Collaborator

👍

Copy link
Collaborator

@orangesamus orangesamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now

@Valdorff Valdorff merged commit c43d911 into rocket-pool:main Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants