Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bunch more fuzzing bugs #7353

Merged
merged 20 commits into from
Dec 14, 2024

Conversation

joshuawarner32
Copy link
Collaborator

  • Fix bug found in the wild via fuzzing, move fuzzing job to the end
  • Fix bug with when not passing down options
  • Force newlines after multi-line tuple pattern elements
  • Implement better comparisons between alias and body
  • Fix missing indent call (Fuzzer bug test_syntax panic with push_str: ( with text #7346)
  • Fix newlines after multiline apply func pattern (Fuzzer bug test_syntax ((1# )Q a:t n) #7342)
  • Fully normalize in expr record-like things, during formatting
  • Normalize return's 'after'
  • Don't mix spaces before/after the field separator
  • Generalize RecordAccess special-cases to include TupleAccess
  • Don't drop spaces before return
  • Refactor pattern apply
  • Fix multiline str pattern newline multiplication
  • Fix empty SpaceBefore instance
  • lift to spaces in ann_lift_to_node default case
  • clippy

@@ -67,3 +62,8 @@ jobs:

- name: test website build script
run: bash www/build.sh

- name: run fuzz tests - ok to merge if this one fails # for now!
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current CI setup seems to disallow merging PRs with failed CI steps unless an override is given by someone like Anton or Richard. Could we maybe put || true after the last step or something to prevent people from getting blocked? Unfortunately, GitHub doesn't support "allow-failure" yet, and likely won't for some time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you removed this file before this comment was posted, feel free to ignore.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this happened because of some rebase schenanigans locally. Good tip on the ||true, as a way to bring this back slowly (later).

@joshuawarner32 joshuawarner32 merged commit a2f8a1d into roc-lang:main Dec 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants