-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a bunch more fuzzing bugs #7353
Fix a bunch more fuzzing bugs #7353
Conversation
fe2b081
to
2389040
Compare
.github/workflows/ubuntu_x86_64.yml
Outdated
@@ -67,3 +62,8 @@ jobs: | |||
|
|||
- name: test website build script | |||
run: bash www/build.sh | |||
|
|||
- name: run fuzz tests - ok to merge if this one fails # for now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current CI setup seems to disallow merging PRs with failed CI steps unless an override is given by someone like Anton or Richard. Could we maybe put || true
after the last step or something to prevent people from getting blocked? Unfortunately, GitHub doesn't support "allow-failure" yet, and likely won't for some time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you removed this file before this comment was posted, feel free to ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this happened because of some rebase schenanigans locally. Good tip on the ||true, as a way to bring this back slowly (later).
push_str: ( with text
#7346)((1# )Q a:t n)
#7342)