Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzing bug test_syntax "Formatting bug; formatting is not stable" #7359

Closed
lukewilliamboswell opened this issue Dec 13, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working formatting Relates to the roc formatter parsing Relates to the Parsing compiler stage

Comments

@lukewilliamboswell
Copy link
Collaborator

Run on @joshuawarner32 branch for #7353

$ cargo run --bin minimize expr todo
    Finished dev [unoptimized + debuginfo] target(s) in 0.39s
     Running `target/debug/minimize expr todo`
Error found: Initial parse failed: Expr(Pattern(Start(@0), @0), @0)
Proceeding with minimization
Successfully minimized, new length: 42
Successfully minimized, new length: 12
Successfully minimized, new length: 3
No more minimizations found
Final result:
1,
Formatting bug; formatting is not stable.
Original code:
1,A5Q,A
1,A5A,A
,1
,01
,A5











"""















g






















d""""INFO: exiting: 19712 time: 146s
@lukewilliamboswell lukewilliamboswell added bug Something isn't working formatting Relates to the roc formatter parsing Relates to the Parsing compiler stage labels Dec 13, 2024
@joshuawarner32
Copy link
Collaborator

Hmm this one seems to have gotten corrupted. Can you upload the original file? e.g fuzzing should have ended with a line that looks like this:

artifact_prefix='/Users/joshw/src/github.com/roc-lang/roc/crates/compiler/test_syntax/fuzz/artifacts/fuzz_expr/'; Test unit written to /Users/joshw/src/github.com/roc-lang/roc/crates/compiler/test_syntax/fuzz/artifacts/fuzz_expr/crash-94d31a614ec259c9ba5d19c793fbdb442b7b912e

If the file at the path after "Test unit written to" still exists on disk, that'd be very useful

@lukewilliamboswell
Copy link
Collaborator Author

Added .txt so GH would accept it

crash-811d6a1d210d35180bb14b1e7fbfeb2591115dec.txt

@joshuawarner32
Copy link
Collaborator

Thanks!
Looks like this was fixed by one of the fixes I made along the way (not sure which one...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working formatting Relates to the roc formatter parsing Relates to the Parsing compiler stage
Projects
None yet
Development

No branches or pull requests

2 participants