Upgrade to purity inference #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_value_def_suffixed
|
No need to worry about valgrind on nix, the next step is this. |
This was referenced Dec 10, 2024
| @@ -7,7 +7,7 @@ lto = true | |||
| strip = "debuginfo" | |||
| # You can comment this out if you hit a segmentation fault similar to the one in see issue github.com/roc-lang/roc/issues/6121 | |||
| # Setting this to 1 should improve execution speed by making things easier to optimize for LLVM. | |||
| codegen-units = 1 | |||
| # codegen-units = 1 | |||
There was a problem hiding this comment.
I'm not sure what's going on here. I don't remember changing this
There was a problem hiding this comment.
Oh, probably should update that back to codegen-units = 1 in a follow up
Comment on lines
+71
to
+74
| # not used, leaving here for future reference if we want to run valgrind on an example | ||
| # if [ "$no_ext_name" == "args" ] && command -v valgrind &> /dev/null; then | ||
| # valgrind $EXAMPLES_DIR/args argument | ||
| # fi |
There was a problem hiding this comment.
Leaving this here for future... we went to all the effort to use valgrind
bhansconnect
approved these changes
Dec 11, 2024
Comment on lines
+10
to
+14
| # TODO | ||
| # I deleted the Arg parser as a workaround for issues it was causing when upgrading to purity inference. | ||
| # The plan is for people so use Weaver or simmilar in future. We can discuss putting it back in if we still | ||
| # want the "batteries included" experience, but either way that will need to be upgraded/tested with | ||
| # purity-inference. |
There was a problem hiding this comment.
TODO note... I can remove this in this or follow up, I left this here for @Anton-4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.