DO NOT MERGE update Str.fromUtf8 error type #7321
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhansconnect
approved these changes
Dec 9, 2024
|
@Anton-4 any release management changes we need to do for a more fundamental type change to a builtin? This is likely to break some code, but for a really good reason. |
|
Thanks for pinging me @bhansconnect, we should hold this for a bit so we can get the breaking changes for this in together with roc-lang/basic-cli#257 for the next basic-cli release. |
Anton-4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent here is to change the error type of
Str.fromUtf8to be a little more scrutible. To that end, the unnamed arguments have been replaced with a record withproblemandindexfield that hopefully makes it a little clearer.fixes #1020