Find the external meshes in the local file system #798
Conversation
CHANGELOG.md
Outdated
| @@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| ### Added | |||
| - Add the possibility to plot and update frames in the Matlab visualizer. | |||
| - Added ``getFileLocationOnLocalFileSystem`` method in ``ExternalMesh`` that attempt to find the mesh location in the local file system | |||
There was a problem hiding this comment.
Can we specify that this is now used when using the visualizer?
| if(isFileExisting(filename)) | ||
| { | ||
| return filename; | ||
| } | ||
|
|
There was a problem hiding this comment.
This ensure that the current use case of specifying files without a package:// URI file is still supported, right?
There was a problem hiding this comment.
Yes, if filename is already the path of a file, it simply returns it as it is.
|
cc @singhbal-baljinder this should permit to use the visualizer without any more specific hacks. |
|
Related issue: #799 (that can be in any case addressed after this PR has been merged). |
Fixed a few typos in the docs and in the changelog.
|
Actually, there were a couple of bugs in the Windows branching. Indeed, I haven't tested it in WIndows 😅 |
|
So, did you tested on Windows now? Is this ready to be merged? |
I haven't yet. I will |
I just tested it in Windows too. It seems to be working (apart from the usual headaches when testing something on Windows)
|
|
Perfect, can you resolve the conflicts so that we can merge? Thanks! |
|
Actually, I forgot to mention that it did not work out of the box, simply because right now we don't define the |
I opened an issue for this: robotology/robotology-superbuild#577 . |
|
By the way, how did you installed irrlicht on Windows? vcpkg? |
A bit worst than that, just a bit 😁 I downloaded the precompiled version from Sourceforge, I added the |
cc @GiulioRomualdi
Fix #291 .