Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment conventional call numbers on restart_call() #930

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

taclane
Copy link
Contributor

@taclane taclane commented Feb 21, 2024

Conventional calls are assigned a call number when they are first created, and continue to reuse that same call_num for every subsequent call.

While this reuse has no negative technical effects, it is not ideal from the standpoint of logging or reporting to have non-unique numbers as a call identifier.

This patch simply increments the call_num on each Call_conventional::restart_call().

@robotastic
Copy link
Owner

Brilliant!

@robotastic robotastic merged commit 8b2a58b into robotastic:rc/v5.0 Feb 22, 2024
@taclane taclane deleted the conv-callnum2 branch March 6, 2024 16:25
taclane added a commit to taclane/trunk-recorder that referenced this pull request Mar 6, 2024
commit 8269e80
Author: decoy4fun <[email protected]>
Date:   Mon Mar 4 20:06:03 2024 -0700

    broadcastify_uploader.cc - minor log level adjustment (robotastic#916)

    "Rejected" status previously logged at an 'info' level. This quick change will now show as an error if Broadcastify rejects your upload.

commit d9594f5
Author: Nick <[email protected]>
Date:   Mon Mar 4 22:05:00 2024 -0500

    Use the JSON lib to generate call end data (robotastic#927)

    * use the json lib for call info

    * patched TGs are not strings

commit 8465370
Author: Luke Berndt <[email protected]>
Date:   Wed Feb 21 22:28:39 2024 -0500

    improved signal detection auto threshold

commit d0371ed
Author: Luke Berndt <[email protected]>
Date:   Wed Feb 21 20:32:17 2024 -0500

    better formatting

commit 8b2a58b
Author: Nick <[email protected]>
Date:   Wed Feb 21 20:21:44 2024 -0500

    increment conventional call numbers on restart (robotastic#930)

commit ed528c9
Author: Luke Berndt <[email protected]>
Date:   Tue Feb 20 22:18:58 2024 -0500

    moving the squelch before the decoders and cleaned up Signal msg

commit 5c2e615
Author: Luke Berndt <[email protected]>
Date:   Tue Feb 20 21:14:56 2024 -0500

    clarify TPS Decode error

commit 9fd963d
Author: Luke Berndt <[email protected]>
Date:   Tue Feb 20 21:09:20 2024 -0500

    make initial Signal & Noise values more obvious

commit 179babe
Author: Luke Berndt <[email protected]>
Date:   Mon Feb 19 23:21:57 2024 -0500

    fixed it!

commit 1d8cc56
Author: Luke Berndt <[email protected]>
Date:   Mon Feb 19 23:13:05 2024 -0500

    Almost there...

commit 62f6322
Author: Luke Berndt <[email protected]>
Date:   Mon Feb 19 22:27:27 2024 -0500

    why shouldn't we collect Power from pwr_squelch_cc()? 🤔

commit 761ff94
Author: Luke Berndt <[email protected]>
Date:   Mon Feb 19 21:45:21 2024 -0500

    reset the RSSI for each new conv call

commit 2b05816
Author: Luke Berndt <[email protected]>
Date:   Mon Feb 19 09:18:49 2024 -0500

    cleaning things up

commit e348cd2
Author: Luke Berndt <[email protected]>
Date:   Sun Feb 18 17:20:12 2024 -0500

    Calc signal strength less often - improve threshold

commit 5b1e1ee
Author: ge0metrix <[email protected]>
Date:   Wed Feb 14 22:04:09 2024 -0500

    Update GitHub workflow to build docker images on RC commit (robotastic#922)

    Had to re-file this PR because workflows are run based on the workflow definition in the branch, not the main branch.

commit e3e0b5d
Author: Luke Berndt <[email protected]>
Date:   Sat Feb 10 10:52:02 2024 -0500

    signal detector auto-threshold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants