Use the JSON lib to generate call end data #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a great idea - merging it in for testing |
taclane
added a commit
to taclane/trunk-recorder
that referenced
this pull request
Mar 6, 2024
commit 8269e80 Author: decoy4fun <[email protected]> Date: Mon Mar 4 20:06:03 2024 -0700 broadcastify_uploader.cc - minor log level adjustment (robotastic#916) "Rejected" status previously logged at an 'info' level. This quick change will now show as an error if Broadcastify rejects your upload. commit d9594f5 Author: Nick <[email protected]> Date: Mon Mar 4 22:05:00 2024 -0500 Use the JSON lib to generate call end data (robotastic#927) * use the json lib for call info * patched TGs are not strings commit 8465370 Author: Luke Berndt <[email protected]> Date: Wed Feb 21 22:28:39 2024 -0500 improved signal detection auto threshold commit d0371ed Author: Luke Berndt <[email protected]> Date: Wed Feb 21 20:32:17 2024 -0500 better formatting commit 8b2a58b Author: Nick <[email protected]> Date: Wed Feb 21 20:21:44 2024 -0500 increment conventional call numbers on restart (robotastic#930) commit ed528c9 Author: Luke Berndt <[email protected]> Date: Tue Feb 20 22:18:58 2024 -0500 moving the squelch before the decoders and cleaned up Signal msg commit 5c2e615 Author: Luke Berndt <[email protected]> Date: Tue Feb 20 21:14:56 2024 -0500 clarify TPS Decode error commit 9fd963d Author: Luke Berndt <[email protected]> Date: Tue Feb 20 21:09:20 2024 -0500 make initial Signal & Noise values more obvious commit 179babe Author: Luke Berndt <[email protected]> Date: Mon Feb 19 23:21:57 2024 -0500 fixed it! commit 1d8cc56 Author: Luke Berndt <[email protected]> Date: Mon Feb 19 23:13:05 2024 -0500 Almost there... commit 62f6322 Author: Luke Berndt <[email protected]> Date: Mon Feb 19 22:27:27 2024 -0500 why shouldn't we collect Power from pwr_squelch_cc()? 🤔 commit 761ff94 Author: Luke Berndt <[email protected]> Date: Mon Feb 19 21:45:21 2024 -0500 reset the RSSI for each new conv call commit 2b05816 Author: Luke Berndt <[email protected]> Date: Mon Feb 19 09:18:49 2024 -0500 cleaning things up commit e348cd2 Author: Luke Berndt <[email protected]> Date: Sun Feb 18 17:20:12 2024 -0500 Calc signal strength less often - improve threshold commit 5b1e1ee Author: ge0metrix <[email protected]> Date: Wed Feb 14 22:04:09 2024 -0500 Update GitHub workflow to build docker images on RC commit (robotastic#922) Had to re-file this PR because workflows are run based on the workflow definition in the branch, not the main branch. commit e3e0b5d Author: Luke Berndt <[email protected]> Date: Sat Feb 10 10:52:02 2024 -0500 signal detector auto-threshold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using file operations to emulate the creation of call JSON, this should be handled by the new JSON library. This should ultimately be easier to maintain, less prone to typo errors, and provide easier-to-read output.
Upon call completion, the call information is first collected into an
ordered_jsonobject before being written to disk with two-space indentation.This json object is now included in the
Call_Data_tstruct, and passed back tocall_infoafter generation. Doing so allows upload plugins to have direct access to this call end data without re-reading the .json file, or including a redundant method to recreate it locally.