Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ff-env-var-test #17

Closed
wants to merge 1 commit into from
Closed

ff-env-var-test #17

wants to merge 1 commit into from

Conversation

robdiciuccio
Copy link
Owner

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Apr 7, 2021

Codecov Report

Merging #17 (774f815) into master (c35e84e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   79.04%   79.04%           
=======================================
  Files         936      936           
  Lines       47411    47411           
  Branches     5778     5875   +97     
=======================================
+ Hits        37476    37478    +2     
+ Misses       9809     9807    -2     
  Partials      126      126           
Flag Coverage Δ
cypress 56.06% <ø> (ø)
javascript 68.85% <ø> (ø)
mysql 80.57% <ø> (ø)
postgres 80.61% <ø> (ø)
python 80.69% <ø> (ø)
sqlite 80.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/filters/utils.ts 95.23% <0.00%> (-4.77%) ⬇️
...et-frontend/src/dashboard/components/Dashboard.jsx 89.47% <0.00%> (+4.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c35e84e...774f815. Read the comment docs.

@robdiciuccio
Copy link
Owner Author

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link

github-actions bot commented Apr 7, 2021

@robdiciuccio Ephemeral environment spinning up at http://54.212.102.63:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@github-actions
Copy link

Ephemeral environment shutdown and build artifacts deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants