feat: Support feature flag overrides in ephemeral test envs #14008
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14008 +/- ##
==========================================
- Coverage 78.64% 78.08% -0.57%
==========================================
Files 935 944 +9
Lines 47375 48069 +694
Branches 5973 6146 +173
==========================================
+ Hits 37260 37533 +273
- Misses 9972 10388 +416
- Partials 143 148 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| let results = []; | ||
| [...context.payload.comment.body.matchAll(pattern)].forEach(match => { | ||
| const config = { | ||
| name: `SUPERSET_FEATURE_${match[1]}`, |
There was a problem hiding this comment.
Why do we need to prefix these with SUPERSET_?
There was a problem hiding this comment.
Namespacing and convention with other superset env vars.
| { | ||
| k[len("SUPERSET_FEATURE_") :]: bool(strtobool(v)) | ||
| for k, v in os.environ.items() | ||
| if re.search(r"^SUPERSET_FEATURE_\w+", k) |
There was a problem hiding this comment.
tiny nit but startswith might be simpler here
|
Thank you so much Rob!!!!! @srinify let's highlight this in our next release note :) |
…4008) * Add support for feature flag overrides in ephemeral env cmd * update docs to reference correct config * Update ephemeral env docs
…4008) * Add support for feature flag overrides in ephemeral env cmd * update docs to reference correct config * Update ephemeral env docs
mistercrunch
added
🏷️ bot
SUMMARY
Adds support for feature flag overrides in ephemeral test environments. Also adds support for setting feature flags via environment variables prefixed with
SUPERSET_FEATURE_.TEST PLAN
This functionality won't be available until it is merged to
master. It has been tested here.ADDITIONAL INFORMATION