Skip to content
This repository has been archived by the owner on Jun 27, 2024. It is now read-only.

fix: do not add/remove workers in debug mode #96

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Conversation

rustatian
Copy link
Member

Reason for This PR

  • Workers should not be added in debug mode.

Description of Changes

  • Restrict Add/Remove operations in debug mode.
  • Correct Remove operation, remove if len > 0 check.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Sep 24, 2023
@rustatian rustatian requested a review from wolfy-j September 24, 2023 12:02
@rustatian rustatian self-assigned this Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #96 (0e54ba9) into master (736fe1f) will decrease coverage by 0.40%.
The diff coverage is 0.00%.

❗ Current head 0e54ba9 differs from pull request most recent head 5c537da. Consider uploading reports for the commit 5c537da to get more accurate results

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
- Coverage   77.49%   77.10%   -0.40%     
==========================================
  Files          23       23              
  Lines        2066     2070       +4     
==========================================
- Hits         1601     1596       -5     
- Misses        410      418       +8     
- Partials       55       56       +1     
Files Changed Coverage Δ
pool/static_pool/workers_pool.go 68.35% <0.00%> (-2.39%) ⬇️
worker_watcher/worker_watcher.go 86.73% <ø> (-1.19%) ⬇️

... and 1 file with indirect coverage changes

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian merged commit 653726f into master Sep 24, 2023
@rustatian rustatian deleted the fix/dynamic-workers branch September 24, 2023 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant