fix: do not add/remove workers in debug mode

Signed-off-by: Valery Piashchynski <[email protected]>
roadrunner-server · Sep 24, 2023 · 0e54ba9 · 0e54ba9
1 parent 736fe1f
commit 0e54ba9
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/pool/static_pool/workers_pool.go b/pool/static_pool/workers_pool.go
@@ -119,6 +119,10 @@ func (sp *Pool) Workers() (workers []*worker.Process) {
 }
 
 func (sp *Pool) RemoveWorker(ctx context.Context) error {
+	if sp.cfg.Debug {
+		sp.log.Warn("remove worker operation is not allowed in debug mode")
+		return nil
+	}
 	var cancel context.CancelFunc
 	_, ok := ctx.Deadline()
 	if !ok {
@@ -130,6 +134,10 @@ func (sp *Pool) RemoveWorker(ctx context.Context) error {
 }
 
 func (sp *Pool) AddWorker() error {
+	if sp.cfg.Debug {
+		sp.log.Warn("add worker operation is not allowed in debug mode")
+		return nil
+	}
 	return sp.ww.AddWorker()
 }
 

diff --git a/worker_watcher/worker_watcher.go b/worker_watcher/worker_watcher.go
@@ -75,11 +75,6 @@ func (ww *WorkerWatcher) AddWorker() error {
 }
 
 func (ww *WorkerWatcher) RemoveWorker(ctx context.Context) error {
-	// we can't remove worker if there are no workers :)
-	if ww.container.Len() == 0 {
-		return nil
-	}
-
 	w, err := ww.Take(ctx)
 	if err != nil {
 		return err