-
-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update iOS library + Potential CI fixes #609
Conversation
…to fix CI issues with yarn and add lock file for example project
Closes #592 |
@kristfal, I actually have a question about npm vs yarn: I've to admit, that I've also added to the confusion by adding |
@ferdicus we're using yarn on travis as there were some caching related issues on travis with npm i was not able to solve, and could work around by going with yarn. |
That pretty much summarizes the issue. I generally have less issues with yarn, so adopted it across most of my work. Btw, I just double checked that we need to run the example repo without a yarn lock file due to sha integrity issues between published and locally build rnmgl package. This shouldn’t be an issue since the distributed build doesn’t depend on anything in the example folder. Also removed NPM lock file to avoid confusion. I’ll add package lock to gitignore to prevent future issues/confusion with NPM and yarn. |
Agreed. Does this mean, that we're going to be opinionated towards |
It doesn’t really matter much for consumers, and not really for contributors either. Feel free to use whatever you prefer. The most important thing is that if you use yarn, the lock file guarantees that what you install locally will be installed identical on the CI. Not using a lock file may (under very special circumstances) produce different versions of dependency installs. |
Update iOS SDK to latest version.
Regenerate yarn.lock for main repo to fix CI issues with yarn and add lock file for example project.