Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update native iOS library version and download endpoints #592

Closed
lgzajac opened this issue Jan 1, 2020 · 4 comments · Fixed by #681
Closed

Update native iOS library version and download endpoints #592

lgzajac opened this issue Jan 1, 2020 · 4 comments · Fixed by #681

Comments

@lgzajac
Copy link
Contributor

lgzajac commented Jan 1, 2020

Hi!

This is not exactly a bug (tho related to #388, btw, i am using npm version 7.0.8), but dependency issue.

Mapbox splitted core repos (mapbox/mapbox-gl-native#15971) and looks like dep-fu is not tracking it.

Current version of android lib is 8.6.0 (https://github.com/mapbox/mapbox-gl-native-android/releases/tag/android-v8.6.0), with a lot of changes since 8.2.1.

Would it be possible to update it asap? I will try to fix it on my own and create a pull request, but since this can be not trivial change, i could be not able to.

Regards and thanx for great work

@mfazekas
Copy link
Contributor

mfazekas commented Jan 1, 2020

@lgzajac pls do a PR, i don't think depfu has ever tracked native deps. I think only npm deps from pacakge.json.

See https://github.com/react-native-mapbox-gl/maps/pull/196 for an example PR that updated versions

@ferdicus
Copy link
Member

ferdicus commented Jan 1, 2020

I think only npm deps from pacakge.json.

Right, depfu only checks js (&/or ruby deps).

@kristfal
Copy link
Member

Updated Android is in master. I'll change this title to iOS.

@kristfal kristfal changed the title Mapbox native libs updates/repository split Update native iOS library version and download endpoints Jan 10, 2020
mfazekas added a commit that referenced this issue Feb 21, 2020
@mfazekas
Copy link
Contributor

iOS was updated to 5.6 with podfile

mfazekas added a commit to mfazekas/maps-1 that referenced this issue Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants