Remove dependence on qBittorrent session cookie being named SID
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmartin16
force-pushed
the
user-config-cookie-name
branch
from
89e7cf9 to
45402ae
Compare
Codecov Report
@@ Coverage Diff @@
## main #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 1917 1924 +7
Branches 566 563 -3
=========================================
+ Hits 1917 1924 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
rmartin16
force-pushed
the
user-config-cookie-name
branch
from
45402ae to
03441c6
Compare
rmartin16
force-pushed
the
user-config-cookie-name
branch
2 times, most recently
from
30438ac to
c73b09e
Compare
rmartin16
force-pushed
the
user-config-cookie-name
branch
from
c73b09e to
d0c0361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the qBittorrent session cookie is now configurable via qbittorrent/qBittorrent#18384.
My initial go at this simply allowed the user to declare the name of the cookie being used. However, this can only be done when
Clientis initialized. Therefore, if the cookie name is changed or just a different qBittorrent host shows up, then theClientwill need to be recreated altogether.This client strives to always establish a successful connection for any API request as long as the username/password is correct. This may be possible if qBittorrent exposed the name of the cookie via an API method....but either way, this strategy just removes the dependence on knowing what the session cookie is at all.