WebAPI: Allow to specify session cookie name

[glassez]

Closes #18329.

[brvphoenix]

It may be useful to add a command line parameter (and/or an environment variable) to define the cookie name.

[glassez]

It may be useful to add a command line parameter (and/or an environment variable) to define the cookie name.

Environment variable is unlikely to be useful since it will affect all the instances but this option is mostly to use different cookie name per instance.

[brvphoenix]

It may be useful to add a command line parameter (and/or an environment variable) to define the cookie name.

Environment variable is unlikely to be useful since it will affect all the instances but this option is mostly to use different cookie name per instance.

Prepending a single command with environment variable will take effect for that command only, for example, FOO=bar qbittorrent-nox in linux terminal. The windows CMD can also set local variable by SETLOCAL. I'm not familiar with WSL. If the cookie name can be set by a command line parameter, it should also be OK.

[glassez]

It may be useful to add a command line parameter (and/or an environment variable) to define the cookie name.

Environment variable is unlikely to be useful since it will affect all the instances but this option is mostly to use different cookie > Prepending a single command with environment variable will take effect for that command only, for example, FOO=bar qbittorrent-nox in linux terminal. The windows CMD can also set local variable by SETLOCAL. I'm not familiar with WSL.

Ok. Thank you for explanation.

If the cookie name can be set by a command line parameter, it should also be OK.

In any case, let's leave all this for future improvements, if there really is a need for them.

[sledgehammer999]

Token approval. I haven't tested this.

[sledgehammer999]

It may be useful to add a command line parameter (and/or an environment variable) to define the cookie name.

FYI, and since last time I checked, our "cmd options code" automatically creates an ENV lookup for each cmd option. I don't know if this has changed over the last year.
EDIT: To clarify, each option can be both passed as an ENV or cmd option. IIRC ENV takes precedence.

[sledgehammer999]

IIRC ENV takes precedence.

It's the other way around. See qbittorrent --help for details.

[sledgehammer999]

This is a very general remark and I don't know if this has been discussed already.
For regex we should consider switching to raw string literals. It will improve regex readability by dropping the need for backslash escapes.
However, I don't know if raw string literals can mix with user-defined literals (_qs).

[glassez]

I don't know if this has been discussed already.
For regex we should consider switching to raw string literals.

We didn't discuss such a requirement earlier.

It will improve regex readability by dropping the need for backslash escapes.

Personally, I don't care about it in trivial cases like this. In complex regexps, it really makes sense.
However, if you see the point of making this a requirement for regular expressions, I don't mind. But in this case, it would be good to start by converting all existing instances, so that later some newly-minted contributors do not poke their finger there when they are pointed out to such a requirement.

[sledgehammer999]

I am not keen into make it a hard requirement. You should treat it more like a suggestion IMO.
Do you think it should be a requirement?

[glassez]

Do you think it should be a requirement?

No.