Added waits for UDEV rules (copy of @philfifi's pull) #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made await_permissions test path absolute, fixed incorrect usage of chmod.
Formatted code to make it PEP8 compliant
|
Only took me 5 tries to get the damn thing to build 😊 |
|
I'll have a look at the weekend if thats ok - give me a nudge if I haven't reviewed by end of Sunday 😬 |
|
Hi. I forgot to give you that nudge, so here it is 👉 |
rm-hull
approved these changes
Sep 15, 2018
This was referenced Sep 15, 2018
|
This was rolled into v0.3.3, but I skipped sending that to PyPi, so it is published in v0.3.4 |
|
Awesome. Thanks for your work on this project :) |
|
Hello, thanks for making that action :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw Phil's pull request was not seeing any action, so I thought I'd do it myself. 😊
I don't actually know how to run tests (never used pytest) so I don't know if they will pass. I have however written them and added documentation.