Wait permissions to be set #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before accessing sysfs files. This is useful in the case a udev rules in run to fix the permissions of the GPIO.
Repository owner
deleted a comment from
coveralls
Oct 5, 2017
Repository owner
deleted a comment from
coveralls
Oct 5, 2017
Repository owner
deleted a comment from
coveralls
Oct 5, 2017
Repository owner
deleted a comment from
coveralls
Oct 5, 2017
rm-hull
reviewed
Oct 5, 2017
There was a problem hiding this comment.
- There are 5 bits of identical functionality -> these should be abstracted into a single method
- Please add some tests to cover the branches in the new method
- Please add some context (in the docstrings) about what problem this solves and what other things need to happen (e.g. how to add specific udev rules)
|
Thanks for the comments, I'll fix that and propose a new patch. |
|
We already use https://pypi.python.org/pypi/pyfakefs so it should be relatively easy to fake out scenarios where the file permissions are not set as expected. |
|
Merged #28 in preference to this PR (identical functionality) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before accessing sysfs files. This is useful in the case a
udev rules in run to fix the permissions of the GPIO.
This fixes #14