Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typescript definition of toIdSchema(), and passed the new idSeparator prop through to the AnyOfField and OneOfField inside of SchemaField #2743

Merged
merged 7 commits into from
Mar 3, 2022
Merged

Update typescript definition of toIdSchema(), and passed the new idSeparator prop through to the AnyOfField and OneOfField inside of SchemaField #2743

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e7babd6
Follow-up fix to #2628
heath-freenome Mar 2, 2022
e24420d
- Also passed `idSeparator` through to the `AllOfField` and `OneOfFie…
heath-freenome Mar 2, 2022
f6e293d
- Updated `CHANGELOG.md`
heath-freenome Mar 2, 2022
1ec339d
- Updated `ArrayField` to also pass `idPrefix` and `idSeparator` down…
heath-freenome Mar 2, 2022
9797dfd
- Optimized `ArrayField` to get `idPrefix` and `idSeparator` directly…
heath-freenome Mar 2, 2022
6a091c5
- Added test to validate nesting of `idPrefix` and `idSeparator` in `…
heath-freenome Mar 3, 2022
70c30d4
- Updated the `CHANGELOG` per reviewer feedback
heath-freenome Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@ should change the heading of the (upcoming) version to include a major version b
-->
# v5.0.0 (coming soon)

# v4.0.2 (upcoming)
# v4.0.3 (upcoming)

# v4.0.2

## @rjsf/core

- To improve performance, skip validating subschemas in oneOf / anyOf if formData is undefined (#2676)
- Fixed the definition of the `toIdSchema()` typescript definition to add new `idSeparator` prop
heath-freenome marked this conversation as resolved.
Show resolved Hide resolved

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the PR title to note the 3 things that were changed?

# v4.0.1

Expand Down
Loading