-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript definition of toIdSchema(), and passed the new idSeparator
prop through to the AnyOfField
and OneOfField
inside of SchemaField
#2743
Changes from all commits
e7babd6
e24420d
f6e293d
1ec339d
9797dfd
6a091c5
70c30d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -819,6 +819,8 @@ class ArrayField extends Component { | |
uiSchema={itemUiSchema} | ||
formData={itemData} | ||
errorSchema={itemErrorSchema} | ||
idPrefix={this.props.idPrefix} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this an optimization or a bug fix? If the latter, maybe let's add a test to ensure it doesn't regress. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is closer to a bug fix as the props weren't being propagated all the way down... I can add a test There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @epicfaace Test pushed... Did you want to reapprove or shall I merge? |
||
idSeparator={this.props.idSeparator} | ||
idSchema={itemIdSchema} | ||
required={this.isItemRequired(itemSchema)} | ||
onChange={this.onChangeForIndex(index)} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the PR title to note the 3 things that were changed?