Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nicer displaying of 1 instruction loops #3396

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

lorsanta
Copy link
Contributor

@lorsanta lorsanta commented Dec 1, 2024

Your checklist for this pull request

Detailed description

Ref #3369

Test plan (required)

I compiled

.globl _main
_start:
movq $1, %rax
loop:
jmp loop
jmp loop2
loop2:
movq $3, %rax
jmp .
jmp .
loop3:
movq $2, %rax
jmp loop3

with gcc -nostdlib hello.s -o hello and this is the result:

Screenshot from 2024-12-01 14-11-49

Closing issues

Closes #3369

@XVilka XVilka requested a review from karliss December 1, 2024 13:29
@wargio
Copy link
Member

wargio commented Dec 1, 2024

Looks good!

Copy link
Member

@karliss karliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough.

@karliss karliss merged commit 6e894a1 into rizinorg:dev Dec 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nicer displaying of 1 instruction loops
3 participants