Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer displaying of 1 instruction loops #3369

Closed
karliss opened this issue Aug 10, 2024 · 2 comments · Fixed by #3396
Closed

Nicer displaying of 1 instruction loops #3369

karliss opened this issue Aug 10, 2024 · 2 comments · Fixed by #3396
Labels
Enhancement Label requests for new features or to improve existing ones good first issue Easy issues for new comers. Nice-To-Have Issues tagged with this label are considered low priority UI

Comments

@karliss
Copy link
Member

karliss commented Aug 10, 2024

Is your feature request related to a problem? Please describe.

When displaying jump lines (or whatever the name for lines to the left of disassembly are called) for instructions that jump to themselves (infinite loop).

image

I initially thought the line drawing code has bugged out. Took me a couple of seconds to read the disassembly until I realized what's going on.

Describe the solution you'd like

Add special case in the drawing code when instruction jumps to itself, maybe draw a loop arrow icon similar to
image

As a side effect it would also help more easily identify such single instruction infinite loops. For me that doesn't seem too important since normal code would rarely contain such (possibly infinite) loops although it shouldn't hurt either. I have mostly seen them in interrupt vector handlers on embedded software. There might be cases on some architectures where you can make more meaningful loops out of single instruction, but nothing comes to my mind right now. My primary motivation is to avoid drawing something that looks like drawing code is broken.

Describe alternatives you've considered

Slightly offset start end/of such arrows resulting in something like:
image
Didn't we have something like that before? I though I have seen it , but I might be remembering it wrong. Or maybe those were jumps 1 instruction forward/back.

Additional context

@karliss karliss added Enhancement Label requests for new features or to improve existing ones good first issue Easy issues for new comers. UI Nice-To-Have Issues tagged with this label are considered low priority labels Aug 10, 2024
@Rohan-here
Copy link

can i work on this?

@wargio
Copy link
Member

wargio commented Sep 15, 2024

sure.

lorsanta added a commit to lorsanta/cutter that referenced this issue Dec 1, 2024
@karliss karliss closed this as completed in 6e894a1 Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Label requests for new features or to improve existing ones good first issue Easy issues for new comers. Nice-To-Have Issues tagged with this label are considered low priority UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants