Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Add support for the Zicond ISA extension #59

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

cmuellner
Copy link
Contributor

The upcoming Zicond ISA extension introduces two new instructions:

  • czero.eqz
  • czero.nez

This patch adds these instructions to template.yaml.

The Zicond ISA extension is documented here:
https://github.com/riscv/riscv-zicond/blob/main/zicondops.adoc

cmuellner added a commit to cmuellner/riscv-arch-test that referenced this pull request Mar 21, 2023
This patch intoduces a coverage model and the generated
test cases using riscv_ctg.

The tests have been generated using the following command:
  riscv_ctg.py \
    --cgf coverage/dataset.cgf \
    --cgf coverage/zicond.cgf \
    -bi rv32i \
    -d tests/
  riscv_ctg.py \
    --cgf coverage/dataset.cgf \
    --cgf coverage/zicond.cgf \
    -bi rv64i \
    -d tests64/

The resulting tests have been copied to the target directory:
  cp tests/*S riscv-test-suite/rv32i_m/Zicond/src/
  cp tests64/*S riscv-test-suite/rv64i_m/Zicond/src/

This PR depends on Zicond support in the riscv-ctg repo:
  riscv-software-src/riscv-ctg#59

Signed-off-by: Christoph Müllner <[email protected]>
cmuellner added a commit to cmuellner/riscv-arch-test that referenced this pull request Mar 21, 2023
This patch intoduces a coverage model and the generated
test cases using riscv_ctg.

The tests have been generated using the following command:
  riscv_ctg.py \
    --cgf coverage/dataset.cgf \
    --cgf coverage/zicond.cgf \
    -bi rv32i \
    -d tests/
  riscv_ctg.py \
    --cgf coverage/dataset.cgf \
    --cgf coverage/zicond.cgf \
    -bi rv64i \
    -d tests64/

The resulting tests have been copied to the target directory:
  cp tests/*S riscv-test-suite/rv32i_m/Zicond/src/
  cp tests64/*S riscv-test-suite/rv64i_m/Zicond/src/

This PR depends on Zicond support in the riscv-ctg repo:
  riscv-software-src/riscv-ctg#59

Signed-off-by: Christoph Müllner <[email protected]>
@pawks
Copy link
Collaborator

pawks commented Mar 22, 2023

Please add an example cgf file with the coverpoints also under the sample_cgfs directory. Further, you will need to add a changelog entry and a version update before the PR can be merged.

The upcoming Zicond ISA extension introduces two new instructions:
* czero.eqz
* czero.nez

This patch adds these instructions to template.yaml.

The Zicond ISA extension is documented here:
  https://github.com/riscv/riscv-zicond/blob/main/zicondops.adoc

Signed-off-by: Christoph Müllner <[email protected]>
@cmuellner
Copy link
Contributor Author

I have added the zicond.cgf that I have added in the ACT PR and the change log entry.

pawks
pawks previously approved these changes Mar 29, 2023
@pawks
Copy link
Collaborator

pawks commented Mar 29, 2023

@cmuellner The version of the tool has not been updated. Please run the following command to update the version.

bumpversion --no-tag --config-file setup.cfg patch

@cmuellner
Copy link
Contributor Author

Updated PR with the additional version bump commit generated by bumpversion.

@pawks pawks merged commit 3208c42 into riscv-software-src:master Apr 4, 2023
cmuellner added a commit to cmuellner/riscv-arch-test that referenced this pull request Nov 17, 2023
This patch intoduces a coverage model and the generated
test cases using riscv_ctg.

The tests have been generated using the following command:
  riscv_ctg.py \
    --cgf coverage/dataset.cgf \
    --cgf coverage/zicond.cgf \
    -bi rv32i \
    -d tests/
  riscv_ctg.py \
    --cgf coverage/dataset.cgf \
    --cgf coverage/zicond.cgf \
    -bi rv64i \
    -d tests64/

The resulting tests have been copied to the target directory:
  cp tests/*S riscv-test-suite/rv32i_m/Zicond/src/
  cp tests64/*S riscv-test-suite/rv64i_m/Zicond/src/

This PR depends on Zicond support in the riscv-ctg repo:
  riscv-software-src/riscv-ctg#59

Signed-off-by: Christoph Müllner <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants