Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TEST_JALR_OP macro that used the LA macro in ways incompatible with GCC later than 2023-12-20 #446

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fixed TEST_JALR_OP macro that used the LA macro in ways incompatible with GCC later than 2023-12-20 #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# CHANGELOG

## [3.8.10] -- 2024-03-24
- Updated TEST_JALR_OP in test_macros.h
- The macro no longer works when rd = x0 in versions of GCC newer than 2023.12.20
- riscof throws a message /home/jstine/cvw/addins/riscv-arch-test/riscv-test-suite/rv32i_m/I/src/jalr-01.S:72: Error: illegal operands `la x0,5b'
- The TEST_JALR_OP macro invokes LA, which does not like x0 as an operand
- replacing LA(rd, 5b) with auipc rd, 0 in test_macros.h solves the compiler issue and produces similar code but without a bunch of preceeding nops

## [3.8.9] -- 2024-01-12
- Fixed Check ISA fields to include 32/64 in Zicond tests. Note that the riscv-ctg CGFs have not been updated.

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/env/test_macros.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@

#define TEST_JALR_OP(tempreg, rd, rs1, imm, swreg, offset,adj) ;\
5: ;\
LA(rd,5b) ;\
auipc rd, 0 ;\
.if adj & 1 == 1 ;\
LA(rs1, 3f-imm+adj-1) ;\
jalr rd, imm+1(rs1) ;\
Expand Down
Loading