Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed TEST_JALR_OP macro that used the LA macro in ways incompatible with GCC later than 2023-12-20 #446

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

davidharrishmc
Copy link
Contributor

Description

  • Updated TEST_JALR_OP in test_macros.h
  • The macro no longer works when rd = x0 in versions of GCC newer than 2023.12.20
  • riscof throws a message /home/jstine/cvw/addins/riscv-arch-test/riscv-test-suite/rv32i_m/I/src/jalr-01.S:72: Error: illegal operands `la x0,5b'
  • The TEST_JALR_OP macro invokes LA, which does not like x0 as an operand in the latest GCC
  • replacing LA(rd, 5b) with auipc rd, 0 in test_macros.h solves the compiler issue and produces similar code but without a bunch of preceeding nops

Related Issues

NA

Ratified/Unratified Extensions

  • [ I ] Ratified
  • Unratified

List Extensions

I

Reference Model Used

  • [x ] SAIL
  • [x ] Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • [n/a ] All tests are compliant with the test-format spec present in this repo ?
  • [ y ] Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • [ n ] Ran the new tests on RISCOF in coverage mode
  • [ n ] Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • [ n ] Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • [ y ] Changelog entry created with a minor patch

Optional Checklist:

  • [n ] RISCV-V CTG PR link if tests were generated using it : < SPECIFY HERE >
  • [n ] Were the tests hand-written/modified ?
  • [y ] Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
    https://github.com/openhwgroup/cvw/pull/677/files
  • [ n ] If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

Copy link
Collaborator

@allenjbaum allenjbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix this issue (though it really is a tool issue...)

@allenjbaum
Copy link
Collaborator

Simple fix for a tool issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants