Add support for rest pattern #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
rest-pattern
branch
from
cb7ac70 to
3d22745
Compare
GuillaumeGomez
force-pushed
the
rest-pattern
branch
from
3d22745 to
c860a22
Compare
|
Rebased and fixed clippy. CI is finally happy. :) |
Kijewski
reviewed
Jul 31, 2024
rinja_parser/src/target.rs
Outdated
| if let Target::Rest(s) = target { | ||
| if !allow_named_rest && s.inner.is_some() { | ||
| return Err(nom::Err::Failure(ErrorContext::new( | ||
| format!("`@ ..` cannot be used in {type_kind}"), |
There was a problem hiding this comment.
Rust uses "@ .. is only allowed in slice patterns". I like that better, because it tells you what you can do, instead of what you can't do.
The code looks fine, so if you like the current phrasing better, then it's not a showstopper for me!
There was a problem hiding this comment.
No you're right, I prefer your version. Updating!
|
And done. :) |
Kijewski
reviewed
Jul 31, 2024
rinja_parser/src/target.rs
Outdated
| if let Target::Rest(s) = target { | ||
| if !allow_named_rest && s.inner.is_some() { | ||
| return Err(nom::Err::Failure(ErrorContext::new( | ||
| format!("`@ ..` is only allowed in slice patterns"), |
There was a problem hiding this comment.
The format!() is not needed anymore.
There was a problem hiding this comment.
Even clippy was complaining about it. :3
GuillaumeGomez
force-pushed
the
rest-pattern
branch
from
674c7ff to
4de78ad
Compare
Kijewski
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #101, I added support for it.