Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ready for v0.3.0? #101

Closed
Kijewski opened this issue Jul 28, 2024 · 11 comments · Fixed by #107
Closed

Ready for v0.3.0? #101

Kijewski opened this issue Jul 28, 2024 · 11 comments · Fixed by #107

Comments

@Kijewski
Copy link
Collaborator

We have added and changed a lot since the first release. Do you think we are ready for 0.2.1? I think rinja_parser has to get bumped to 0.3.0, because we added removed enum members, but the current HEAD should be compatible to rinja + rinja_derive 0.2.0.

What do you think, @GuillaumeGomez? Do you have something you wish to add or change before we do the next release?

@GuillaumeGomez
Copy link
Contributor

Actually yes! I wanted to add slice pattern matching before a new release. But that's the only thing I can think of on my side.

@Kijewski
Copy link
Collaborator Author

Yes, that can be quite a useful feature, too! I guess the parsing is 99% the same as parsing tuples, except for the delimiters.

@Kijewski
Copy link
Collaborator Author

Or do you want to implement if let [b'H', b'i', b' ', who @ .., b'!'] = b"Hi world!", too? I guess that could be difficult. https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=ea373fd285476e52d131a83724293372

@GuillaumeGomez
Copy link
Contributor

I suppose the whole @ .. should be implemented. Gonna be fun. :3

@GuillaumeGomez
Copy link
Contributor

Should we make the release now (I'll let you make this one 😛)? Gonna work on the b/c prefixes later on. Gonna open an issue for that.

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 2, 2024

Will do a release later this evening (CEST). :)

@Kijewski Kijewski reopened this Aug 2, 2024
@Kijewski Kijewski changed the title Ready for v0.2.1? Ready for v0.3.0? Aug 2, 2024
@GuillaumeGomez
Copy link
Contributor

Yeay! \o/

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 2, 2024

@Kijewski Kijewski closed this as completed Aug 2, 2024
@GuillaumeGomez
Copy link
Contributor

Wow looks nice! I wonder if we could automate that too. XD

Anyway, thanks a lot, it's awesome! Announcing on socials.

@Kijewski
Copy link
Collaborator Author

Kijewski commented Aug 3, 2024

When you click on Releases, then on the top-right there is a button "draft new release". There you can select the newest tag, and with "Generate release notes" you get the same output as in my release message. :)

Unless I forget it, I check the "Create a discussion for this release" box, so the easier to answer questions or any comments to the release can get consolidated into one page

@GuillaumeGomez
Copy link
Contributor

Oh nice, thanks for the information! We should put it in a "releasing.md" file to have the list of things we need to do when releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants