Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This IDL is fine for languages where everything is by-reference. But for C++, it tries to embed a class by-value into its self, which cannot succeed, and results in compilation failure. See jaegertracing#35 This has been worked around by patching the IDL-generated code; see jaegertracing/jaeger-client-cpp#45 . It turns out we can just tell Thrift to include the optional member by-reference. See the comment in https://issues.apache.org/jira/browse/THRIFT-4484 about `cpp.ref`. Apparently that's now spelled `&` in Thrift IDL. I don't know what effect it has for other languages, the documentation is sparse at best, and doesn't mention this at all. If this doesn't break other languages I think it's the correct fix for the IDL.
- Loading branch information