Add PHP namespace (jaegertracing#40)

ringerc · Nov 16, 2017 · 6710b74 · 6710b74
1 parent 347af16
commit 6710b74
Show file tree

Hide file tree

Showing 9 changed files with 10 additions and 1 deletion.
diff --git a/Makefile b/Makefile
@@ -10,8 +10,9 @@ SWAGGER=docker run --rm -it -u ${shell id -u} -v "${PWD}:/go/src/${PROJECT_ROOT}
 THRIFT_GO_ARGS=thrift_import="github.com/apache/thrift/lib/go/thrift"
 THRIFT_PY_ARGS=new_style,tornado
 THRIFT_JAVA_ARGS=private-members
+THRIFT_PHP_ARGS=psr4
 
-THRIFT_GEN=--gen go:$(THRIFT_GO_ARGS) --gen py:$(THRIFT_PY_ARGS) --gen java:$(THRIFT_JAVA_ARGS) --gen js:node --gen cpp
+THRIFT_GEN=--gen go:$(THRIFT_GO_ARGS) --gen py:$(THRIFT_PY_ARGS) --gen java:$(THRIFT_JAVA_ARGS) --gen js:node --gen cpp --gen php:$(THRIFT_PHP_ARGS)
 THRIFT_CMD=$(THRIFT) -o /data $(THRIFT_GEN)
 
 THRIFT_FILES=agent.thrift jaeger.thrift sampling.thrift zipkincore.thrift crossdock/tracetest.thrift \

diff --git a/thrift/agent.thrift b/thrift/agent.thrift
@@ -17,6 +17,7 @@ include "zipkincore.thrift"
 
 namespace cpp jaegertracing.agent.thrift
 namespace java com.uber.jaeger.agent.thrift
+namespace php Jaeger.Thrift.Agent
 namespace netcore Jaeger.Thrift.Agent
 
 service Agent {

diff --git a/thrift/aggregation_validator.thrift b/thrift/aggregation_validator.thrift
@@ -14,6 +14,7 @@
 
 namespace cpp jaegertracing.thrift
 namespace java com.uber.jaeger.thriftjava
+namespace php Jaeger.Thrift.Agent
 namespace netcore Jaeger.Thrift.Agent
 
 # ValidateTraceResponse returns ok when a trace has been written to redis.

diff --git a/thrift/baggage.thrift b/thrift/baggage.thrift
@@ -14,6 +14,7 @@
 
 namespace cpp jaegertracing.thrift
 namespace java com.uber.jaeger.thriftjava
+namespace php Jaeger.Thrift.Agent
 namespace netcore Jaeger.Thrift.Agent
 
 # BaggageRestriction contains the baggage key and the maximum length of the baggage value.

diff --git a/thrift/crossdock/tracetest.thrift b/thrift/crossdock/tracetest.thrift
@@ -14,6 +14,7 @@
 
 namespace cpp jaegertracing.crossdock.thrift
 namespace java com.uber.jaeger.crossdock.thrift
+namespace php Jaeger.Thrift.Crossdock
 namespace netcore Jaeger.Thrift.Crossdock
 
 enum Transport { HTTP, TCHANNEL, DUMMY }

diff --git a/thrift/dependency.thrift b/thrift/dependency.thrift
@@ -14,6 +14,7 @@
 
 namespace cpp jaegertracing.thrift
 namespace java com.uber.jaeger.thriftjava
+namespace php Jaeger.Thrift.Agent
 namespace netcore Jaeger.Thrift.Agent
 
 struct DependencyLink {

diff --git a/thrift/jaeger.thrift b/thrift/jaeger.thrift
@@ -14,6 +14,7 @@
 
 namespace cpp jaegertracing.thrift
 namespace java com.uber.jaeger.thriftjava
+namespace php Jaeger.Thrift
 namespace netcore Jaeger.Thrift
 
 # TagType denotes the type of a Tag's value.

diff --git a/thrift/sampling.thrift b/thrift/sampling.thrift
@@ -14,6 +14,7 @@
 
 namespace cpp jaegertracing.sampling_manager.thrift
 namespace java com.uber.jaeger.thrift.sampling_manager
+namespace php Jaeger.Thrift.Agent
 namespace netcore Jaeger.Thrift.Agent
 
 enum SamplingStrategyType { PROBABILISTIC, RATE_LIMITING }

diff --git a/thrift/zipkincore.thrift b/thrift/zipkincore.thrift
@@ -15,6 +15,7 @@ namespace cpp twitter.zipkin.thrift
 namespace java com.twitter.zipkin.thriftjava
 #@namespace scala com.twitter.zipkin.thriftscala
 namespace rb Zipkin
+namespace php Jaeger.Thrift.Agent.Zipkin
 namespace netcore Jaeger.Thrift.Agent.Zipkin
 
 #************** Annotation.value **************