Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The advice about Actions if conditional operators is removed. #22

Closed
shogo82148 opened this issue Aug 4, 2021 · 4 comments
Closed

The advice about Actions if conditional operators is removed. #22

shogo82148 opened this issue Aug 4, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@shogo82148
Copy link
Contributor

actionlint warns if conditions without ${{ ... }}.

this expression must be contained within ${{ }} like if: ${{ ... }} since it contains operator ".". see https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif for more details [expression]

but, I can't find its source in https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif
It looks that it is removed recently: github/docs#8786

@rhysd
Copy link
Owner

rhysd commented Aug 4, 2021

Thank you letting me know. The change was really recently, just one hour ago: github/docs#8786

We should remove the check.

@rhysd rhysd added the bug Something isn't working label Aug 4, 2021
@rhysd
Copy link
Owner

rhysd commented Aug 4, 2021

Since omitting ${{ }} on if: is very common and the advice is raised frequently, I think we need to remove the check and release patch version quickly.

@rhysd
Copy link
Owner

rhysd commented Aug 4, 2021

The fix was shipped with v1.5.3 release.

@shogo82148
Copy link
Contributor Author

Thank you for your quickly fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants