Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove advice about Actions if conditional operators #8786

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

lucascosti
Copy link
Contributor

@lucascosti lucascosti commented Aug 4, 2021

Why:

Closes #8700

What's being changed:

Remove advice about Actions if conditional operators. if conditions don't need to be enclosed in ${{ }}. Our examples still show ${{ }} because it helps avoid yaml escaping issues.

Stage preview: https://docs-8786--lucascosti-patch-1.herokuapp.com/en/actions/reference/context-and-expression-syntax-for-github-actions#about-contexts-and-expressions

Check off the following:

  • I have reviewed my changes in staging (look for the latest deployment event in your pull request's timeline, then click View deployment).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Aug 4, 2021
Copy link
Contributor

@martin389 martin389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@lucascosti lucascosti merged commit 96177a5 into main Aug 4, 2021
@lucascosti lucascosti deleted the lucascosti-patch-1 branch August 4, 2021 04:54
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect documentation regarding omitting the expression syntax for if conditionals
2 participants