Get list of installer image packages when probing boot.iso #1229
Conversation
|
/test-os-variants |
rvykydal
force-pushed
the
gather-list-of-packages-when-probing-boot-iso
branch
from
006ad59 to
31837f4
Compare
|
/test-os-variants |
| ISO_PACKAGES=$(echo "${output}" | grep 'PACKAGES=') | ||
| ISO_PACKAGES="${ISO_PACKAGES##PACKAGES=}" | ||
| echo Saving list of installer image packages to /var/tmp/kstest-image-packages.log | ||
| echo $ISO_PACKAGES | tr ' ' '\n' | tee /var/tmp/kstest-image-packages.log |
There was a problem hiding this comment.
If I read this correctly then the list of packages will get printed to stdout. If this is correct I think it would spam the test results a lot wouldn't it? Isn't it enough to just store the list?
There was a problem hiding this comment.
If the tests pass, you do not need to worry about extra lines in the output, if there is a failure it might be handy to see the package versions right in the test output. I actually like it this way :-)
There was a problem hiding this comment.
I think in this case it is handy to have this in the main log output without need of making sure we really pass / gather all the required logs (for example in GH actions). Also it is maybe more discoverable this way. Actually this information is very important when dealing with integration tests failures so let's make it as easily accessible as possible.
|
Yes, it seems to me that it creates a mess in GH actions console output: I think we should remove use of |
| ISO_PACKAGES=$(echo "${output}" | grep 'PACKAGES=') | ||
| ISO_PACKAGES="${ISO_PACKAGES##PACKAGES=}" | ||
| echo Saving list of installer image packages to /var/tmp/kstest-image-packages.log | ||
| echo $ISO_PACKAGES | tr ' ' '\n' | tee /var/tmp/kstest-image-packages.log |
There was a problem hiding this comment.
If the tests pass, you do not need to worry about extra lines in the output, if there is a failure it might be handy to see the package versions right in the test output. I actually like it this way :-)
I already replied earlier, also given we even already have the debugging shell output above I don't see it as a problem. |
You can see the change in action in the /test-os-variants workflow of this PR, step "Run kickstart tests in container" (near "Saving list of installer image packages to /var/tmp/kstest-image-packages.log")
or in logs / artefacts of the workflow (eg logs-daily-iso) where you can find kstest-image-packages.log.