Configurable terminal program #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roy Golan <[email protected]>
Signed-off-by: Roy Golan <[email protected]>
rgolangh
force-pushed
the
configure-terminal-program
branch
13 times, most recently
from
3ca358f to
1f34853
Compare
benyaminl
reviewed
Oct 13, 2024
| show_apply_button: true, // Allows user to apply the input | ||
| }); | ||
| behaviourGroup.add(terminalRow); | ||
| window._settings.bind("terminal", terminalRow, "text", Gio.SettingsBindFlags.DEFAULT); |
There was a problem hiding this comment.
Just a silly question
Does gnome extension use mvvm to set the config, and we only need to set a new schema of the config then it just automatically has storage for saving it?
I seen on https://gjs.guide/extensions/development/preferences.html#gsettings
But well I never code it, just making sure.
Thank you
There was a problem hiding this comment.
I don't how the internal backend system for gsettengs works, I just use the API. It is used for a lot other gnome related configurations, not only for extensions though.
rgolangh
force-pushed
the
configure-terminal-program
branch
2 times, most recently
from
038aa01 to
ae0bb1a
Compare
The extension preferences has a new entry for the terminal program to use for running the commands in a terminal. The default value is "gnome-terminal --" which is the current behaviour. Here are terminal values that were tested and worked: "gnome-terminal --" "ptyxis --" "kitty" "flatpak run com.gexperts.Tilix -e" "flatpak run app.studiodev.Ptyxis --" Signed-off-by: Roy Golan <[email protected]>
- migrate to eslint 9 - migrate .eslint.yaml to eslint.config.mjs Signed-off-by: Roy Golan <[email protected]>
rgolangh
force-pushed
the
configure-terminal-program
branch
from
ae0bb1a to
97226e7
Compare
Signed-off-by: Roy Golan <[email protected]>
Signed-off-by: Roy Golan <[email protected]>
Signed-off-by: Roy Golan <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support configuring the terminal program
The extension preferences has a new entry for the terminal program to
use for running the commands in a terminal.
The default value is "gnome-terminal --" which is the current behaviour.
Here are terminal values that were tested and worked:
"gnome-terminal --"
"ptyxis --"
"kitty"
"flatpak run com.gexperts.Tilix -e"
"flatpak run app.studiodev.Ptyxis --"
Fixes: #57