[Feature Request] There are options for Change targeted terminal

[benyaminl]

Hello, I just want to ask, is it possible to change the

gnome-shell-extension-containers/src/modules/podman.js

Lines 266 to 268 in 0d76598

	cmdline = `gnome-terminal -- bash -c '${command} ${containerName} ${args};read i'`;
	} else {
	cmdline = `gnome-terminal -- ${command} ${containerName} ${args}`;

With other terminal command?

I'm on gnome but I'm not using gnome-terminal (sorry, haha...)

Or I need to change the code myself for that?

Thank you

EDIT:

For now I do have workaround by making gnome-terminal shell script to get the command using xfce4-terminal
/usr/local/bin/gnome-terminal

#!/bin/bash
if [ $1 == '--' ]; then
  shift
  xfce4-terminal -x $@
else
  xfce4-terminal $@
fi  

[rgolangh]

Thanks for reporting this.
👍 +1 for clever script , but I would hate to force you do that. I think it should be easy to put that in a setting, and fallback to gnome terminal otherwise.

[rgolangh]

@benyaminl can you please checkout the branch from #58 and configure your terminal? I don't have an installation with xfce4 at the moment. I did test few other terminals, some run as flatpaks.

[benyaminl]

@benyaminl can you please checkout the branch from #58 and configure your terminal? I don't have an installation with xfce4 at the moment. I did test few other terminals, some run as flatpaks.

Yeah, thanks man it works

Just the process of running from the alpha/test version is quite strange I guess, I need to logout and relogin to make the new version works.

the command line for xfce terminal is

xfce4-terminal -x , with extra space in the end. like gnome-terminal -- . I think this need to be conveyed to the user? *or based on the extension, you can assume, most user is developer so.. they know it. haha..

EDIT: without extra space, terminal works

[rgolangh]

what do you see in the journalctl and what happens if you don't add the space?
I tested here with a script, similar to what you did, and I don't see the space is needed.

[benyaminl]

@rgolangh sorry, seems it works as it's without space, I just retest it.