Contruct a container object by podman version #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will now build a container object and extract the info from the json output by the podman version. Now we can make the extension work with various podman version and break less often by those changes. Signed-off-by: Roy Golan <[email protected]>
rgolangh
force-pushed
the
gnome-shell-3.36
branch
from
b4b5731 to
f29f00b
Compare
|
My user is @rmarting 😄 Anyway it was a pleassure to help you. |
noted and fixed 🤦 🎊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will now build a container object and extract the info from
the json output by the podman version.
Now we can make the extension work with various podman version and break
less often by those changes.
Credit and many thanks to @rmarting 🙏 who sent this #14 which drove me to invest some time in making the code better suited for multi versions.
Signed-off-by: Roy Golan [email protected]