✨ Updated to podman 2.0.3 json format #14
Conversation
podman 2.0.3 json format includes a set of differences in the schema (e.g: Names as an array, State instead of Status, ...). This commit includes some changes to update them.
Using locale configuration of the user to show the creation timestamp
|
|
||
| | branch | gnome-shell version | | ||
| | --- | --- | | ||
| | master | 3.36.1 | | ||
| | 3.36 | 3.36.4 | |
There was a problem hiding this comment.
The podman version is something that needs handling as well. I'm thinking on adding per podman release json parsing handling. Some people may newer version of gnome but old podman versions and vice versa.
|
@rmarting thank yo so much for this. This is not the first time podman breaks. Hopefully this is Important note about indentation - its deliberately like that and taken from many source code examples in the gnome-shell repo. |
| this.menu.addMenuItem(new PopupMenuItem("Id", container.Id)); | ||
| this.menu.addMenuItem(new PopupMenuItem("Image", container.Image)); | ||
| this.menu.addMenuItem(new PopupMenuItem("Command", container.Command)); | ||
| this.menu.addMenuItem(new PopupMenuItem("Created", timeConverter(container.Created))); |
There was a problem hiding this comment.
We can actually just use CreatedAt
|
Do you think that my changes could be integrated for a new release of the extension? TBH I am not following the latest changes in Podman space, and I am not an expert in gnome-extension life cycle ... so you, as owner, could choose the best approach. If I could help you in other thing, I am glad to do it. |
|
I'm going to close this in favour of something bit more generic #15 - thanks a lot for this PR! |
|
Cool Roy! Your approach is more clean than my initial proposal. I like it! |
podman 2.0.3 json format includes a set of differences in the schema (e.g: Names as an array, State instead of Status, ...).
This commit includes some changes to update them.
With these minimal changes the gnome extension works successfully again with podman 2.0.3. Some extra staff should be done to manage:
Createdattribute with some human readable format.Portsarray in a human readable format.Some changes are described in the following issues in podman: