ms2deepscore #40
Merged
ms2deepscore #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an ms2deepscore workflow + vignette
jorainer
requested changes
Feb 5, 2025
There was a problem hiding this comment.
Thanks Matthias! The vignette is very helpful and we can build on that! I would however suggest to move it to the inst/doc folder. All files within the vignettes folder are expected to be working out-of-the-box and will be rendered during package building (and testing - which currently fails).
Also, if I understand, the R/ms2deepscore.R contains the R code from the vignettes/ms2deepscore.Rmd? In that case I would suggest to remove the file - we can later use the vignette to add dedicated functions to SpectriPy - or just have the vignette that describes how the analysis can be done manually.
Removed separate .R file and moved .Rmd file to inst/doc
Added file downloads for model and test data
jorainer
approved these changes
Feb 6, 2025
|
Ah, and before merging @mmattano - can I ask you to please add yourself to the DESCRIPTION with |
Added myself
jorainer
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a workflow to use ms2deepscore in R as part of the EuBIC MS hackathon