fix: While extracting address for GSTIN info, avoid duplicates #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sanket322
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2041 +/- ##
===========================================
+ Coverage 65.31% 65.34% +0.02%
===========================================
Files 105 105
Lines 8731 8737 +6
===========================================
+ Hits 5703 5709 +6
Misses 3028 3028 ☔ View full report in Codecov by Sentry. |
mergify bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* fix: avoid_dupliace in address * refactor: unique address values --------- (cherry picked from commit 17cb1d0)
mergify bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
* fix: avoid_dupliace in address * refactor: unique address values --------- (cherry picked from commit 17cb1d0)
This was referenced Apr 23, 2024
mergify bot
added a commit
that referenced
this pull request
Apr 23, 2024
…tfix/pr-2041 fix: avoid_duplicate in address (backport #2041)
mergify bot
added a commit
that referenced
this pull request
Apr 23, 2024
…tfix/pr-2041 fix: avoid_duplicate in address (backport #2041)
india-compliance-bot
added a commit
that referenced
this pull request
Apr 29, 2024
## [15.7.3](v15.7.2...v15.7.3) (2024-04-29) ### Bug Fixes * **auto-rcm:** tds getting overwritten where rcm template was reset ([#2056](#2056)) ([13fd096](13fd096)) * avoid_duplicate in address ([#2041](#2041)) ([f41dea2](f41dea2)) * avoiding addition of TDS rates for past financial year ([#2077](#2077)) ([9dcb034](9dcb034)), closes [#2068](#2068) * cancel sales invoice if e-Invoice is cancelled ([#2045](#2045)) ([8f9351c](8f9351c)) * correct condition for GST Invoice in case of supply to SEZ ([a29f710](a29f710)) * correct outward supply details using gst treatment ([#2067](#2067)) ([6b24008](6b24008)) * do not throw on "ignore_gst_validations" ([2f30984](2f30984)) * Document Type as `CHL` in case of return Invoice with Nil-rated ([#2028](#2028)) ([ac2c634](ac2c634)) * **excel:** remove default bg colors from excel export ([cb42fbc](cb42fbc)) * handle on cancel for reco tool ([#2046](#2046)) ([a3d53fa](a3d53fa)) * on trash update status dynamically ([ee5256c](ee5256c)) * remove extra inward supplies and unlink invoice ([961abbc](961abbc)) * support tax collector as customer ([#2066](#2066)) ([4d86b21](4d86b21)) ### Performance Improvements * dont create address copy ([f2a77c6](f2a77c6))
india-compliance-bot
added a commit
that referenced
this pull request
Apr 29, 2024
## [14.26.4](v14.26.3...v14.26.4) (2024-04-29) ### Bug Fixes * **auto-rcm:** tds getting overwritten where rcm template was reset ([#2056](#2056)) ([0c77750](0c77750)) * avoid_duplicate in address ([#2041](#2041)) ([5b0cc69](5b0cc69)) * avoiding addition of TDS rates for past financial year ([#2077](#2077)) ([e30ba31](e30ba31)), closes [#2068](#2068) * cancel sales invoice if e-Invoice is cancelled ([#2045](#2045)) ([2ba6807](2ba6807)) * correct condition for GST Invoice in case of supply to SEZ ([937ed11](937ed11)) * correct outward supply details using gst treatment ([#2067](#2067)) ([f4df0be](f4df0be)) * do not throw on "ignore_gst_validations" ([bb59e09](bb59e09)) * Document Type as `CHL` in case of return Invoice with Nil-rated ([#2028](#2028)) ([a331778](a331778)) * **excel:** remove default bg colors from excel export ([54f959b](54f959b)) * handle on cancel for reco tool ([#2046](#2046)) ([b9b9257](b9b9257)) * **minor:** better way to override totals in gst sales beta report ([#2022](#2022)) ([7751af2](7751af2)) * on trash update status dynamically ([9bb6b5d](9bb6b5d)) * remove check digit validation for transporter id ([193c1a8](193c1a8)) * remove extra inward supplies and unlink invoice ([9b363f0](9b363f0)) * support tax collector as customer ([#2066](#2066)) ([c6c33ab](c6c33ab)) * uom as per gst ([#2019](#2019)) ([2caf9e6](2caf9e6)) * validate for cess non-advol ([#2009](#2009)) ([41acfdd](41acfdd)) ### Performance Improvements * dont create address copy ([e74d04a](e74d04a))
Closed
Sanket322
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid duplicate in address_line1 and address_line2 for GSTIN info
closes #1917