Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While extracting address_line2 for GSTIN info, avoid duplicates #1917

Closed
sagarvora opened this issue Mar 22, 2024 · 3 comments · Fixed by #2041
Closed

While extracting address_line2 for GSTIN info, avoid duplicates #1917

sagarvora opened this issue Mar 22, 2024 · 3 comments · Fixed by #2041
Assignees
Labels
bug Something isn't working released

Comments

@sagarvora
Copy link
Member

sagarvora commented Mar 22, 2024

Line of code:

titlecase(value) for key in ("loc", "city") if (value := address.get(key))

Example:

image

(fix also required in apim)

@sagarvora sagarvora added the bug Something isn't working label Mar 22, 2024
@Sanket322 Sanket322 self-assigned this Mar 29, 2024
@vorasmit
Copy link
Member

vorasmit commented Apr 2, 2024

Looks like the problem is with original data source. It's reported with duplicate values to govt.
I suppose we should not alter this, as we do give option to edit.

@india-compliance-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.7.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@india-compliance-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.26.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
4 participants