Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bindings to Promise.allSettled #6137

Closed
wants to merge 6 commits into from
Closed

Add bindings to Promise.allSettled #6137

wants to merge 6 commits into from

Conversation

cometkim
Copy link
Member

zth
zth reviewed Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This should go in https://github.com/rescript-association/rescript-core eventually, but we haven't formulated a v11 strategy for that just yet, and since this won't work without v11, we probably need to do that before.

@zth
Copy link
Collaborator

zth commented Apr 12, 2023

Pressed the wrong button, but this looks good to me!

@cometkim
Copy link
Member Author

I see, I will make PR to @rescript/core too anyway.

@cometkim
Copy link
Member Author

jscomp/gentype_tests/typescript-react-example seems to be broken btw

@cristianoc
Copy link
Collaborator

cristianoc commented Apr 12, 2023 •
edited
Loading

jscomp/gentype_tests/typescript-react-example seems to be broken btw

Can you expand? Not sure genType is up to date with all the latest changes on variants.

In any case "make test-gentype" should give the current status.

@cristianoc
Copy link
Collaborator

cristianoc commented Apr 13, 2023 •
edited
Loading

@cometkim I've extended the PR by adding the missing support for @tag to genType.
This does not mean, though that genType is going to work for this out of the box.
Library types are built-in in genType at the moment.
Perhaps a better time to support this use is when the functionality is added to Core. As we'd want full genType support for everything in Core.

@cometkim
Copy link
Member Author

rebased

@cristianoc
Copy link
Collaborator

@zth suggestions on how to proceed with this?

@cometkim cometkim mentioned this pull request Apr 20, 2023
Merged
@cometkim
Copy link
Member Author

Moved to rescript-lang/rescript-core#204

@cometkim cometkim closed this Mar 18, 2024
@cometkim cometkim deleted the allsettled branch March 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc left review comments

@zth zth zth left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binding to Promise.allSettled
3 participants
@cometkim @zth @cristianoc