Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more bindings to Promise utils #204

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Add more bindings to Promise utils #204

merged 3 commits into from
Apr 2, 2024

Conversation

cometkim
Copy link
Member

@cometkim cometkim mentioned this pull request Mar 18, 2024
Closed
@cometkim cometkim force-pushed the promise-methods branch 4 times, most recently from 94940ef to c4b6902 Compare March 18, 2024 13:23
cknitt
cknitt approved these changes Apr 1, 2024
View reviewed changes
Copy link
Member

@cknitt cknitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍 LGTM!

@zth Ok for you, too?

zth
zth approved these changes Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@zth zth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@zth
Copy link
Collaborator

zth commented Apr 1, 2024

Just need a changelog.

@zth
Copy link
Collaborator

zth commented Apr 2, 2024

@cometkim some rename missing, but other than that this is good to go!

@zth zth merged commit f700b44 into rescript-lang:main Apr 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zth zth zth approved these changes

@cknitt cknitt cknitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cometkim @zth @cknitt