Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerun broken on Emil's iOS Safari and Chrome Android #2032

Closed
emilk opened this issue May 3, 2023 · 8 comments · Fixed by #2296
Closed

Rerun broken on Emil's iOS Safari and Chrome Android #2032

emilk opened this issue May 3, 2023 · 8 comments · Fixed by #2296
Assignees
@emilk
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🔺 re_renderer affects re_renderer itself 🕸️ web regarding running the viewer in a browser

Comments

@emilk
Copy link
Member

emilk commented May 3, 2023 •
edited
Loading

It worked very recently. Now it is stuck on "Loading" with no error message.

Maybe it's my AdBlocker?

This affects my iPhone 12, iOS 16.4.1 (A).

Niko is on iOS 16.3.1, iPhone 11 Pro, has no problem
@emilk emilk added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser 💣 crash crash, deadlock/freeze, do-no-start labels May 3, 2023
@emilk emilk changed the title Rerun broken on mobile Safari Rerun broken on iOS Safari May 16, 2023
@emilk emilk self-assigned this May 16, 2023
@emilk emilk changed the title Rerun broken on iOS Safari Rerun broken on Emil's iOS Safari and Chrome Android May 16, 2023
@jprochazk
Copy link
Member

No adblocker here, also broken on Android Chrome

@emilk
Copy link
Member Author

emilk commented May 16, 2023 •
edited
Loading

This is what I get on my iOS Safari in the dev console:

[Error] panicked at 'wgpu error: Validation Error

Caused by:
    In Device::create_render_pipeline
    Color state [0] is invalid
    Format Rgba8UnormSrgb can't be multisampled

', /home/jp/.cargo/git/checkouts/wgpu-b5b0e12eef369ba9/de497ae/wgpu/src/backend/direct.rs:3019:5

Three things here:

@emilk emilk added the 🔺 re_renderer affects re_renderer itself label May 16, 2023
@emilk emilk mentioned this issue May 16, 2023
Closed
@emilk emilk removed their assignment May 16, 2023
@emilk emilk mentioned this issue May 16, 2023
Merged
1 task
@emilk emilk self-assigned this May 17, 2023
@emilk
Copy link
Member Author

emilk commented May 17, 2023

get_parameter_i32(glow::MAX_SAMPLES) returns 0 on my iPhone, which wgpu interprets as supporting at most 2x MSAA

@emilk emilk mentioned this issue May 17, 2023
Merged
3 tasks
@emilk
Copy link
Member Author

emilk commented May 17, 2023

Fix:

@emilk
Copy link
Member Author

emilk commented May 23, 2023

Is awaiting a wgpu release

@emilk
Copy link
Member Author

emilk commented May 25, 2023

gfx-rs/wgpu#3780 is merged and released as part of 0.16.1, but the fix doesn't seem to take O.o

@emilk emilk mentioned this issue May 25, 2023
Merged
5 tasks
@emilk emilk removed their assignment May 29, 2023
@emilk
Copy link
Member Author

emilk commented May 29, 2023

Currently blocked on weird wasm-bindgen issue:

@emilk emilk self-assigned this May 30, 2023
@emilk
Copy link
Member Author

emilk commented May 30, 2023 •
edited
Loading

So it turns out wgpu 0.16.1 did not include a release of wgpu-hal, which is still on 0.16.0. Since my fix was to wgpu-hal, we don't have the fix in hand yet:

emilk added a commit that referenced this issue Jun 1, 2023
@emilk
Update wgpu-hal to 0.16.1 to fix mobile Safari
66ff1dd 
The release contains gfx-rs/wgpu#3780

Closes #2032
@emilk emilk mentioned this issue Jun 1, 2023
Merged
1 task
emilk added a commit that referenced this issue Jun 1, 2023
@emilk
Update wgpu-hal to 0.16.1 to fix mobile Safari (#2296)
91d8b96 
The release contains gfx-rs/wgpu#3780

Closes #2032

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2296

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/9ebf96a/docs
<!-- pr-link-docs:end -->
emilk added a commit that referenced this issue Jun 15, 2023
@emilk
Update wgpu-hal to 0.16.1 to fix mobile Safari (#2296)
1b73558 
The release contains gfx-rs/wgpu#3780

Closes #2032

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2296

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/9ebf96a/docs
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🔺 re_renderer affects re_renderer itself 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update wgpu-hal to 0.16.1 to fix mobile Safari rerun-io/rerun
2 participants
@emilk @jprochazk