Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panics during startup of web-viewer are not reported to the user #2151

Closed
emilk opened this issue May 16, 2023 · 1 comment · Fixed by #2157
Closed

Panics during startup of web-viewer are not reported to the user #2151

emilk opened this issue May 16, 2023 · 1 comment · Fixed by #2157
Assignees
Labels
🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser

Comments

@emilk
Copy link
Member

emilk commented May 16, 2023

If the web-viewer panics, we should show that as a nice message to our users (in a div). We have code for that in our index.html, but it doesn't work if the crash happens during startup (creating of WebHandle) as in #2032.

This is because the "Have we paniced?" check is installed in on_app_started.

This requires some improvements to eframe (on it)

@emilk emilk added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser labels May 16, 2023
@emilk emilk self-assigned this May 16, 2023
@emilk emilk changed the title Panic in web-viewer not reported to the user Panics during startup of web-viewer are not reported to the user May 16, 2023
@emilk
Copy link
Member Author

emilk commented May 16, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant