-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paging (stack request) functionnalities #708
Paging (stack request) functionnalities #708
Conversation
efaae4a
to
29bfabf
Compare
rero_ils/modules/locations/jsonschemas/locations/location-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/locations/jsonschemas/locations/location-v0.0.1.json
Outdated
Show resolved
Hide resolved
rero_ils/modules/locations/jsonschemas/locations/location-v0.0.1.json
Outdated
Show resolved
Hide resolved
7230501
to
e208136
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message:
- Updates schema location for UCL paging feature.
- Adapts existing features with new locations attributes.
- Updates fixture tests.
?
e208136
to
b175a40
Compare
b175a40
to
2062e10
Compare
8e1c206
to
9fbc355
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Notification should be sent only if the item is on shelf without previous pending loan. Now, a notification is sent to the location even if the item is already in circulation.
- Bug in the following case
- I have a location with pick up restriction (more than 1 pickup locations allowed)
- I edit this location
- I disable the button "Restrict pickup to"
- I cannot save
- In the notification e-mail, the
Date placed
displays the GMT time, we want the local time- Detail: Is
Date placed
correct? I would writeRequest date
instead.
- Detail: Is
- Detail: in the notification e-mail, only the 1st statement of responsibility appears under
Document title
- Detail: the use of icon "truck" for a pickup location in library detailed view could be confusing since this icon is already used for requests in the main menu. The best would be to change the main menu icon, for example with the
shopping-basket
already in use.
Done
Introduced as an issue : #988
Done : Should be test on ilsdev
Done
I used the same method than all other emails (recall, due_soon, ...) send to user.
Done |
fb58457
to
e57912e
Compare
3b13224
to
c1b0343
Compare
This commit implements tasks relative to UCL paging request in closed stack. It allows to limit request for items belonging to specific location. It also allows to restrict the pickup destination to some pickup locations instead of all pickups locations of the organisation. If an item of a "paging" location is requested, it also allows to send a notification to notify a manager. * Adds some tests function to cover new functionalities. * Refactoring circulation actions permissions (can_request, ...) * Increases general code coverage Co-Authored-by: Renaud Michotte <[email protected]>
c1b0343
to
62b1b09
Compare
This commit implements tasks relative to UCL paging request in closed stack.
It allows to limit request for items belonging to specific location.
It also allows to restrict the pickup destination to some pickup locations
instead of all pickups locations of the organisation.
If an item of a "paging" location is requested, it also allows to send
a notification to notify a manager.
how to test
Nee to test with RERO-ILS-UI : rero/rero-ils-ui#171
Code review check list