editor: new wrapper toggle-switch #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
force-pushed
the
zan-#UCLpaging-new-features
branch
2 times, most recently
from
ba7b96b to
1fbc49b
Compare
zannkukai
requested review from
Garfield-fr,
jma and
sebdeleze
and removed request for
jma
sebdeleze
approved these changes
Jan 22, 2020
jma
requested changes
Jan 22, 2020
projects/rero/ng-core/src/lib/record/editor/editor.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/editor/editor.component.ts
Outdated
Show resolved
Hide resolved
projects/rero/ng-core/src/lib/record/editor/toggle-wrapper/toggle-wrappers.component.ts
Show resolved
Hide resolved
| @Component({ | ||
| selector: 'ng-core-editor-formly-toggle-wrapper', | ||
| template: ` | ||
| <div class='toggle-wrapper'> |
There was a problem hiding this comment.
I do not find the styles of toggle-wrapper
There was a problem hiding this comment.
No specific styles are used for toggle-switch.
If bootstrap toggle library is loaded for projec, the display will be a switch (like the screenshoot), otherwise a default checkbox will be displayed.
* Add a new 'toggle-switch' wrapper Co-Authored-by: Renaud Michotte <[email protected]>
zannkukai
force-pushed
the
zan-#UCLpaging-new-features
branch
from
1fbc49b to
870f169
Compare
Garfield-fr
approved these changes
Jan 24, 2020
jma
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Renaud Michotte [email protected]
Why are you opening this PR?
How to test?
Code review check list