editor: set the focus in the forms #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauren-d
requested review from
jma,
Garfield-fr,
iGormilhit,
AoNoOokami and
sebdeleze
lauren-d
force-pushed
the
ucl-#1117-set-focus-in-forms
branch
4 times, most recently
from
be91379 to
9371a57
Compare
|
Please use |
jma
requested changes
Nov 22, 2019
rero_ils/modules/locations/jsonschemas/form_locations/location-v0.0.1.json
Outdated
Show resolved
Hide resolved
...ords/custom-editor/circulation-settings/circulation-policy/circulation-policy.component.html
Show resolved
Hide resolved
lauren-d
force-pushed
the
ucl-#1117-set-focus-in-forms
branch
from
9371a57 to
aab3b52
Compare
iGormilhit
suggested changes
Nov 26, 2019
There was a problem hiding this comment.
Commit message proposition:
editor: set the focus in the forms
* Adds angular directive.
* Updates remote-input component to add autofocus binding.
* Sets the focus in the forms.
* Updates form options to set default focus.
* Closes #542.
Mainly uppercases and verbs at the 3rd singular person. Sorry. 🙂
lauren-d
force-pushed
the
ucl-#1117-set-focus-in-forms
branch
from
aab3b52 to
b793068
Compare
* Adds angular directive. * Updates remote-input component to add autofocus binding. * Sets the focus in the forms. * Updates form options to set default focus. * Closes rero#542. Co-Authored-by: Benoit Erken <[email protected]> Co-Authored-by: Lauren-D <[email protected]>
lauren-d
force-pushed
the
ucl-#1117-set-focus-in-forms
branch
from
b793068 to
723145f
Compare
AoNoOokami
approved these changes
Nov 26, 2019
Garfield-fr
approved these changes
Dec 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Benoit Erken [email protected]
Co-Authored-by: Lauren-D [email protected]
Why are you opening this PR?
How to test?
note: It may be necessary to clear the browser cache
Code review check list